Re: [PATCH] fscrypt: make fscrypt_operations.key_prefix a string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 05.01.2017 um 22:51 schrieb Eric Biggers:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> There was an unnecessary amount of complexity around requesting the
> filesystem-specific key prefix.  It was unclear why; perhaps it was
> envisioned that different instances of the same filesystem type could
> use different key prefixes, or that key prefixes could be binary.

This complexity was also never clear to me.

> However, neither of those things were implemented or really make sense
> at all.  So simplify the code by making key_prefix a const char *.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  fs/crypto/keyinfo.c      | 31 +++++++++++--------------------
>  fs/ext4/ext4.h           | 11 -----------
>  fs/ext4/super.c          | 13 +------------
>  fs/f2fs/f2fs.h           |  9 ---------
>  fs/f2fs/super.c          | 14 +-------------
>  fs/ubifs/crypto.c        | 11 +----------
>  include/linux/fscrypto.h |  2 +-
>  7 files changed, 15 insertions(+), 76 deletions(-)

Reviewed-by: Richard Weinberger <richard@xxxxxx>

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux