On Wed, Jan 4, 2017 at 3:50 AM, Jan Kara <jack@xxxxxxx> wrote: > On Tue 03-01-17 16:11:16, Paul Moore wrote: >> On Mon, Jan 2, 2017 at 1:21 PM, Jan Kara <jack@xxxxxxx> wrote: >> > So I found where the problem was. Attached is a new version of the patch. >> > Tests from audit-testsuite fail for me but do not hang anymore. I guess the >> > failing is because I don't have audit or selinux configured in any way and >> > I'm using SUSE I guess (if there's some easy way to do that, I'd be >> > interested) - runtests.pl complains that I have to be root although I am... >> >> I've never tried running the tests on SUSE, but if audit and SELinux >> are in some undetermined state, then I can only imagine what wierd >> test results you would get. > > Well, the state is well determined - nothing is installed ;) I was kind of > hoping kernel support would be enough but apparently the testsuite needs > some userspace installed & configured as well. Heh, yes :) If nothing is installed you likely missing all the audit userspace tools and auditd probably isn't running; either case would cause massive (complete?) failures in the testsuite. >> I'm building a test kernel as I type this, I'll report back when I have >> some results. > > Thanks! Good news - I looped the testsuite a couple thousand times this afternoon and the VM was still standing afterwards (on a 4.10-rc2 base too!). Let me take a closer look at your revised patch tomorrow (it is getting late for me) and if all is well I'll send it up to Linus. >> Also, while I'm sure you've heard this before (and likely already know >> better), please send patches inline, it makes review/commenting much >> easier. > > Actually, I haven't heard this for quite a long time :) and I myself > prefer attached patches (with text/plain attachment type) when they are > in a reply to another email - they are easier to extract and at least my > mail client automatically inlines them when I hit reply... Arguably the > best of both worlds is to use git-send-email with properly set threading > but I tend to forget about that option. You probably haven't heard this in some time because everyone else isn't as cranky and stubborn as me ;) It isn't a big deal for one small patch with only a few interested parties, but when you get several people discussing the patch it can be very handy to have it inline. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
