On Mon 26-12-16 17:22:58, Amir Goldstein wrote:
> > #ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
> > static int fanotify_get_response(struct fsnotify_group *group,
> > - struct fanotify_perm_event_info *event)
> > + struct fsnotify_mark *inode_mark,
> > + struct fsnotify_mark *vfsmount_mark,
> > + struct fanotify_perm_event_info *event,
> > + int *srcu_idx)
> > {
> > int ret;
> >
> > @@ -69,6 +72,15 @@ static int fanotify_get_response(struct fsnotify_group *group,
> >
> > wait_event(group->fanotify_data.access_waitq, event->response);
> >
> > + if (!fsnotify_prepare_user_wait(inode_mark, vfsmount_mark, srcu_idx)) {
>
> Since it is not clear for reader of this code the conditions where
> fsnotify_prepare_user_wait() can fail, a comment here would be nice
> to explain the choice of ALLOW
Good point. Will add.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
