On Sat, Oct 27, 2007 at 07:10:44PM -0400, Erez Zadok wrote: > Rename old vfs_ioctl to do_ioctl, because the comment above it clearly > indicates that it is an internal function not to be exported to modules; > therefore it should have a more traditional do_XXX name. The new do_ioctl > is exported in fs.h but not to modules. > > Rename the old do_ioctl to vfs_ioctl because the names vfs_XXX should > preferably be reserved to callable VFS functions which modules may call, > as many other vfs_XXX functions already do. Yes, good idea for consistency. > Export the new vfs_ioctl to > modules so others can use it (including Unionfs and eCryptfs). > +EXPORT_SYMBOL(vfs_ioctl); This should be an _GPL export. All new exports for above VFS users like NFSD or stackable filesystem are _GPL because they're not for general consumptions but these rather specific tied to the kernel uses. And while you're at it I'd suggest adding a docbook comment describing the new export vfs_ioctl because we'd eventually like to have the exported API documented fully. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
