On Fri 23-12-16 14:12:19, Amir Goldstein wrote: > On Thu, Dec 22, 2016 at 11:15 AM, Jan Kara <jack@xxxxxxx> wrote: > > Currently we queue all marks for destruction on group shutdown and then > > destroy them from fsnotify_destroy_group() instead from a worker thread > > which is the usual path. However worker can already be processing some > > list of marks to destroy so this does not make 100% all marks are really > > destroyed by the time group is shut down. This isn't a big problem as > > each mark holds group reference and thus group stays partially alive > > until all marks are really freed but there's no point in complicating > > our lives - just wait for the delayed work to be finished instead. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > Isn't it *required* to wait for all marks to really be freed and not only > nice behavior following the same reason for > 35e4817 fsnotify: avoid spurious EMFILE errors from inotify_init() > > Otherwise > > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> Well, it is not nice to leave marks dangling after the group destruction exactly for the reason you reference above. But OTOH it is mostly an annoyance and not a serious issue unless it happens a lot (which it did not in this case). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
