On Thu 22-12-16 18:27:11, Amir Goldstein wrote: > On Thu, Dec 22, 2016 at 11:15 AM, Jan Kara <jack@xxxxxxx> wrote: > > Move recalculation of inode / vfsmount notification mask under > > group->mark_mutex of the mark which was modified. These are the only > > places where mask recalculation happens without mark being protected > > from detaching from inode / vfsmount which will cause issues with the > > following patches. > > > > What am I missing this time? > > dnotify_handle_event() > dnotify_recalc_inode_mask() > fsnotify_recalc_inode_mask() /* not under dnotify_group->mark_mutex */ Dnotify uses mark->lock to protect recalculation of mask which also protects mark from being removed from the list. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
