On Mon, Dec 19, 2016 at 08:59:15PM +0100, Richard Weinberger wrote: > On 19.12.2016 20:15, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > In several places, ubifs checked for an encryption key before creating a > > file in an encrypted directory. This was redundant with > > fscrypt_setup_filename() or ubifs_new_inode(), and in the case of > > ubifs_link() it broke linking to special files. So remove the extra > > checks. > > Thanks for doing this. I assume same or similar changes were also needed > for f2fs and ext4 since I've duplicated the logic from them? :-) > Well all the filesystems are a little different, but I checked link, create, mkdir, mknod, symlink, and tmpfile. UBIFS generally seemed to be the odd one out with regards to having these extra checks: ext4_link(): relies on check in fscrypt_setup_filename() ext4_create(): relies on check in __ext4_new_inode() ext4_mkdir(): relies on check in __ext4_new_inode() ext4_mknod(): relies on check in __ext4_new_inode() ext4_symlink(): relies on __ext4_new_inode() preloading encryption info of new inode ext4_tmpfile(): relies on check in __ext4_new_inode() f2fs_link(): relies on check in fscrypt_setup_filename() f2fs_create(): relies on check in fscrypt_setup_filename() f2fs_mkdir(): relies on check in fscrypt_setup_filename() f2fs_mknod(): relies on check in fscrypt_setup_filename() f2fs_symlink(): has an explicit call to fscrypt_get_encryption_info() because f2fs_new_inode() doesn't preload encryption info of new inode. Check of fscrypt_has_encryption_key() appears unnecessary. f2fs_tmpfile(): has an explicit load of encryption key with no check; it's unclear whether this is sufficient, since it never calls fscrypt_setup_filename() So I am wondering why ext4 "preloads" encryption keys of new inodes but f2fs doesn't, and whether f2fs_tmpfile() is doing the correct checks. But neither fs had all the redundant checks this patch removes from ubifs. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
