Re: [PATCH] fs: try to clone files first in vfs_copy_file_range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 29, 2016 at 12:28:01PM +0200, Amir Goldstein wrote:
> On Tue, Nov 29, 2016 at 10:55 AM, Christoph Hellwig <hch@xxxxxx> wrote:
> > [fullquote removed, please get your email etiquette right or I'll stop
> > responding]
> >
> 
> Sorry. I though the practice was to keep original patch in tact for review.

The practice is to quote what's relevant.  You generally have a lot of
leeway to decide how much exactly you think fits, but a fullquote only
ever makes sense when forwarding the mail to someone not previously
involved with the thread.

> To be fair, Clone is a fast metadata operation on xfs/btrfs/ocfs2.
> I don't think we can know for sure how a future file systems will choose to
> implement clone, nor can we tell for sure how any version of remote Windows CIFS
> server will implement it.

If it's not a fast and atomic metadata operation it must not implement
clone_file_range, but should implement copy_file_range instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux