On Sat, Nov 26, 2016 at 07:09:01PM -0500, Theodore Ts'o wrote: > On Mon, Oct 17, 2016 at 09:54:06AM -0700, Eric Biggers wrote: > > In addition, make the common functions do the copies to and from > > userspace rather than duplicating this code within each filesystem, and > > memset the policy to 0 to make it clear there is no stack leak. > > I don't see any point of doing this, given that we initialize all > parts of the fscrypt_policy structure; and since this structure is > part of UAPI, we can't change it without breaking userspace. > > I'll apply this with the memset (and the above comment in the commit > description) removed. > > - Ted I guess I'm okay with that, since struct fscrypt_policy won't have any padding bytes because its members are all bytes. Plus it's marked __packed, though I think that was a mistake given that the struct isn't stored on disk directly. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
