On Fri, Nov 11, 2016 at 01:11:16AM +0200, Amir Goldstein wrote: > That is explained in commit message of the first 2 patches, but > foremost I would like to say that the name "delete locked" is just the > best of all the bad choices for names I came up with, so I am expecting > better name suggestions. > > The concept is to pin the entry so that it cannot be moved, so can have > certain guaranties about the stability of the directories topology. > > > More specifically, what makes you think that may_delete() is called before > > any change of parent? > > Because it is checked at the beginning of vfs_rename() > and in order to change a parent, an entry needs to be renamed. no? > What am I missing? Analysis of the rest of call chains where we have __d_move() called? Not to mention anything else, workdir itself might be moved around by d_splice_alias() for a sufficiently unpleasant filesystem... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
