On Wed, Oct 26, 2016 at 9:34 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > With overlayfs, it is wrong to compare file_inode(inode)->i_sb > of regular files with those of non-regular files, because the > former reference the real (upper/lower) sb and the latter reference > the overlayfs sb. > > Move the test for same super block after the sanity tests for > clone range of directory and non-regular file. Better: compare ->f_path.dentry->d_sb instead of file_inode()->i_sb. We don't want to be mixing files that come from overlayfs and ones that come from the underlying layers. BTW, would it be worthwhile adding clone_file_range() support to overlayfs? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
