On Fri, Oct 28, 2016 at 2:56 PM, Raphael Hertzog <hertzog@xxxxxxxxxx> wrote: > Hi, > > On Wed, 26 Oct 2016, Miklos Szeredi wrote: >> On Tue, Oct 25, 2016 at 1:57 PM, Raphael Hertzog <hertzog@xxxxxxxxxx> wrote: > > [ redirect feature enabled by default ] > >> I think it would be safe to make it the default if upperdir is empty. >> Nonempty implies that it was created with old kernel (or it was >> crafted by hand). But there should be a way to explicitly turn it >> off; either because of the need for backward compatibility or because >> the old format is simply easier to work with for humans. >> >> How about: >> >> - If upper is nonempty, then leave redirect feature alone except when >> mount option "-oredirect=on" is used to force enabling it. >> - If upper is empty, then enable redirect feature except when mount >> option "-oredirect=off" is used to force disabling it. > > Looks good, but is there some stickyness of the setting? My use case is > schroot and it always starts with an empty upperdir when I create a > temporary/throw-away chroot but if I reboot the machine, then it's possible > that schroot will remount the overlayfs with a non-empty upperdir > (the temporary chroot is preserved until I explicitly end the chroot). Yes, there is stickiness (it stores the "redirect_dir" feature in an extended attribute on upperdir). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
