Amir, On Wed, Oct 26, 2016 at 8:30 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > Since operations on upper are performed using mounter's credentials, > we need to call posix_acl_update_mode() with current credentials on > overlay inode to possibly copy-up and clear setgid bit, before setting > posix ACLs on upper inode. I'll let Miklos decide if this is the right approach. > Also wrap posix acl handlers with #ifdef CONFIG_FS_POSIX_ACL to > avoid compiler warning for implicit declaration of function > 'posix_acl_update_mode' on build without that config option. If you do that, make sure to remove the __maybe_unused declarations in that file well: they were added to silence the compiler when CONFIG_FS_POSIX_ACL isn't set. Or else add a dummy posix_acl_update_mode function to include/linux/posix_acl.h. Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
