On Tue, Oct 18, 2016 at 02:22:07PM +0200, Richard Weinberger wrote: > > Hmm, are you sure the change is worth it? > The patch basically moves a copy_from/to_user() from ext4/f2fs into fscrypto. > Hi Richard, In my opinion consolidating the copy_from/to_user() is worthwhile by itself. The filesystem encryption code should be shared when possible, and right now there's no reason for each filesystem to do its own copy_from/to_user(). The renaming to fscrypt_ioctl_* is also important because it makes it clear that the functions implement ioctls. I've already fixed four bugs in the "set policy" ioctl, and I think these bugs would have been more obvious with a clearer code organization. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
