On Thu, Oct 06, 2016 at 10:00:08AM -0700, Linus Torvalds wrote: > On Thu, Oct 6, 2016 at 9:11 AM, CAI Qian <caiqian@xxxxxxxxxx> wrote: > > > >> > >> Wait. There is also a lockep happened before the xfs internal error as well. > > Some other lockdep this time, > > This one looks just bogus. > > > [ 4872.569797] Possible unsafe locking scenario: > > [ 4872.569797] > > [ 4872.576401] CPU0 > > [ 4872.579127] ---- > > [ 4872.581854] lock(&xfs_nondir_ilock_class); > > [ 4872.586637] <Interrupt> > > [ 4872.589558] lock(&xfs_nondir_ilock_class); > > I'm not seeing that .lock taken in interrupt context. It's a memory allocation vs reclaim context warning, not a lock warning. That overloads the lock vs interrupt lockdep mechanism, so if lockdep sees a context violation it is reported as an "interrupt context" lock problem. The allocation context in question is in a function that can be called from both inside and outside a transaction context. When outside a transaction, it's a GFP_KERNEL allocation, when inside it's a GFP_NOFS context. However, both allocation contexts hold the inode ilock over the allocation. the inode shrinker (reclaim context) also happens to take the inode ilock, and that's what lockdep is complaining about. i.e. it thinks that this path ilock -> alloc(GFP_KERNEL) -> reclaim -> ilock can deadlock. But it can't - the ilock held at the upper side is a referenced inode and can't be seen by reclaim, and the ilocks taken by reclaim are inodes that can't be seen or referenced by the VFS. i.e. There's no depedencies between the ilocks on either side of memory allocation, but there's no way of telling lockdep that short of giving the inodes in reclaim a different lock class. We used to do that, but that was a nasty hack and prevented lockdep from verifying locking orders used on inodes and objects in reclaim matched the locking orders of referenced inodes... We've historically shut these false positives up by simply making all the allocations in these dual context paths GFP_NOFS. However, I recently got told not to do that by someone on the mm side because it exacerbated deficiencies in memory reclaim when too many allocations use GFP_NOFS. So it's not "fixed" and instead I'm ignoring it. If you spend any amount of time running lockdep on XFS you'll get as sick and tired of playing this whack-a-lockdep-false-positive game as I am. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
