On Tue, Oct 04, 2016 at 12:49:43PM +0200, Jan Kara wrote:
> > static struct dentry *isofs_mount(struct file_system_type *fs_type,
> > int flags, const char *dev_name, void *data)
> > {
> > /* We don't support read-write mounts */
> > if (!(flags & MS_RDONLY))
> > return ERR_PTR(-EACCES);
> > return mount_bdev(fs_type, flags, dev_name, data, isofs_fill_super);
> > }
> >
> > This is crazy... iso9600 driver starts analyze mount options although
> > the mount request is maybe completely irrelevant for the driver and
> > there is no iso9600 on the device.
> >
> > If we will write FS drivers in this way then old good "try all from
> > /{proc,etc}/filesystems" will be useless...
> >
> > See another filesystems, for example ext4, first be sure there is
> > superblock and magic string (or return EINVAL) and then try
> > validate mount options.
> >
> > CC to Jan Kara (he did the kernel change in Jun 2013).
>
> Good point. I'll fix iso9660.
Thanks!
I have a patch for mount(8), but it's rather complex, because the
/{proc,etc}/filesystems loop is hidden in libmount. I guess move the
MS_RDONLY check in the iso9660 kernel driver will be easy fix.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
