Re: [PATCH] ext4: optimize ext4 direct I/O locking for reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 30-09-16 01:22:33, Ted Tso wrote:
> I've been looking at your patch and testing it, and it looks like
> works fine as-is.

Glad to hear that!

> The other thing I like about this patch is it allows us to drop
> ext4_inode_{block,resume}_unlocked_dio() and EXT4_STATE_DIOREAD_LOCK.

Well, not completely - we still need to deal with unlocked writes that
happen in ext4_direct_IO_write() when overwrite == 1. But that should be
doable in a similar way. We could just demote inode_lock to a shared mode
instead of dropping it in ext4_direct_IO_write() and then we could drop the
bits you mention above. I can look into that when I'll be looking into
converting ext4 into the new iomap infrastructure but that's definitely
material for the next merge window.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux