On Fri, Sep 30, 2016 at 12:39:34AM -0700, Christoph Hellwig wrote:
> > +/* XFS_IEXT_STATE_TO_FORK() -- Convert BMAP state flags to an inode fork. */
> > +xfs_ifork_t *
> > +XFS_IEXT_STATE_TO_FORK(
> > + struct xfs_inode *ip,
> > + int state)
> > +{
> > + if (state & BMAP_COWFORK)
> > + return ip->i_cowfp;
> > + else if (state & BMAP_ATTRFORK)
> > + return ip->i_afp;
> > + return &ip->i_df;
> > +}
>
> Would be nice to have a lower ase name for this. And while we're at
> it drop duplicating the function name in the top of the function
> comment.
Ok, done.
--D
>
> Othwerise looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
