On Fri, Sep 30, 2016 at 12:26:50AM -0700, Christoph Hellwig wrote: > > +/* The XFS_BMAP_EXTENT_* in xfs_log_format.h must match these. */ > > +enum xfs_bmap_intent_type { > > + XFS_BMAP_MAP = 1, > > + XFS_BMAP_UNMAP, > > +}; > > Meh. Please just use it directly then. > > Otherwise this looks ok, so a conditional: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > based on fixing the above. The log format items actually /do/ store the enum values directly into a u32 now. Evidently I forgot to update the comment. --D -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html