When looking through this patch I've noticed one bug: On Fri 16-09-16 13:27:14, Christoph Hellwig wrote: > +static int ext2_iomap_begin(struct inode *inode, loff_t offset, loff_t length, > + unsigned flags, struct iomap *iomap) > +{ ... > + iomap->offset = first_block << blkbits; Here is a missing cast to u64. Otherwise on 32-bit arch the shift could overflow. I guess DAX is not expected to be used on 32-bit archs but still... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html