[vfs:work.splice_read 10/11] lib/iov_iter.c:532:18: note: in expansion of macro 'min'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.splice_read
head:   9a791e155521e4599ebe1d2fc2ed17fc705d5348
commit: 34ec04831f679ac550a7e695e37cb4ceec6125be [10/11] new iov_iter flavour: pipe-backed
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 34ec04831f679ac550a7e695e37cb4ceec6125be
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   In file included from include/linux/uio.h:12:0,
                    from lib/iov_iter.c:2:
   lib/iov_iter.c: In function 'copy_pipe_to_iter':
   include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast
     (void) (&_min1 == &_min2);  \
                    ^
>> lib/iov_iter.c:532:18: note: in expansion of macro 'min'
      size_t chunk = min(n, PAGE_SIZE - off);
                     ^
   lib/iov_iter.c: In function 'pipe_zero':
   include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast
     (void) (&_min1 == &_min2);  \
                    ^
   lib/iov_iter.c:644:18: note: in expansion of macro 'min'
      size_t chunk = min(n, PAGE_SIZE - off);
                     ^
   lib/iov_iter.c: In function 'pipe_get_pages':
   include/linux/kernel.h:742:17: warning: comparison of distinct pointer types lacks a cast
     (void) (&_min1 == &_min2);  \
                    ^
   lib/iov_iter.c:880:3: note: in expansion of macro 'min'
      min(maxsize, min(npages,maxpages) * PAGE_SIZE - *start),
      ^

vim +/min +532 lib/iov_iter.c

   516	}
   517	
   518	static size_t copy_pipe_to_iter(const void *addr, size_t bytes,
   519					struct iov_iter *i)
   520	{
   521		struct pipe_inode_info *pipe = i->pipe;
   522		size_t n, off;
   523		int idx;
   524	
   525		if (!sanity(i))
   526			return 0;
   527	
   528		bytes = n = push_pipe(i, bytes, &idx, &off);
   529		if (unlikely(!n))
   530			return 0;
   531		for ( ; n; idx = next_idx(idx, pipe), off = 0) {
 > 532			size_t chunk = min(n, PAGE_SIZE - off);
   533			memcpy_to_page(pipe->bufs[idx].page, off, addr, chunk);
   534			i->nr_segs = idx;
   535			i->iov_offset = off + chunk;
   536			n -= chunk;
   537			addr += chunk;
   538		}
   539		i->count -= bytes;
   540		return bytes;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux