On Wed, Sep 21, 2016 at 3:41 PM, Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote: > On Wed, Sep 21, 2016 at 10:30:14AM +0200, Miklos Szeredi wrote: >> 2) You define some constants and structures (POSIX_ACL_*) in >> fuse_common.h that don't seem to belong there. There's <sys/acl.h> >> that contains some parts of that, but I'm not sure how much we want to >> tie libfuse to libacl... It's a difficult thing. Generally I'd try >> to keep the interface as narrow as possible. Perhaps it's enough to >> have a a function to return the equivalent mode from the xattr? > > To be honest I only really meant that to serve as an example of all the > stuff that would need to happen in userspace based on the kernel > implementation. Looking now at libacl I guess it could just be expected > that filesystems will use that. It seems to provide the essentials to do > what I did with fusexmp at least, even an interface for getting the > equivalent mode (acl_equiv_mode). Not sure how well it works if e.g. a > filesystem needs to convert between the posix ACL format and some > different format native to that filesystem. The kernel structures and functions are quite good for converting to native formats (it's simple and easy to encode/decode). So we can use that instead of having to link to libacl, which does seem a not a bit too abstracted. But we should at least try to use the standard names for the constants. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
