On Wed, Sep 14, 2016 at 11:32:47AM -0600, Ross Zwisler wrote: > I think this should be xfs_setfilesize(ip, pos, ret)? 'count' and 'ret' are > the same in non-error cases, but in error cases where iomap_dax_rw() does some > work and then encounters an error, 'ret' could be smaller. In error cases > like this using 'ret' instead of 'count' will also keep the value we use in > i_size_write() equal to what we write via xfs_setfilesize() because > iocb->ki_pos == pos+ret, not pos+count. True. Now with DAX where we can actuall get short writes that should be fixed. I spent too much time with the direct I/O code where this would not happen. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
