[vfs:uaccess-fixes 17/28] arch/powerpc/include/asm/uaccess.h:311:16: warning: unused variable 'over'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git uaccess-fixes
head:   e0d18a84b133198aacb436f5a1c2a6ed97ec0155
commit: 8346f23b615d1890e06cf1fdfe922f6769b7adfd [17/28] ppc32: fix copy_from_user()
config: powerpc-allnoconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 8346f23b615d1890e06cf1fdfe922f6769b7adfd
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/termios-base.h:7:0,
                    from arch/powerpc/include/asm/termios.h:20,
                    from include/uapi/linux/termios.h:5,
                    from include/linux/tty.h:6,
                    from kernel/printk/printk.c:21:
   arch/powerpc/include/asm/uaccess.h: In function 'copy_from_user':
>> arch/powerpc/include/asm/uaccess.h:311:16: warning: unused variable 'over' [-Wunused-variable]
     unsigned long over;
                   ^
   arch/powerpc/include/asm/uaccess.h: In function 'copy_to_user':
   arch/powerpc/include/asm/uaccess.h:325:16: warning: unused variable 'over' [-Wunused-variable]
     unsigned long over;
                   ^

vim +/over +311 arch/powerpc/include/asm/uaccess.h

e68c825b include/asm-powerpc/uaccess.h      Benjamin Herrenschmidt 2007-04-11  295  	__get_user_size(__gu_val, __gu_addr, (size), __gu_err);	\
505e4283 arch/powerpc/include/asm/uaccess.h Michael S. Tsirkin     2014-12-14  296  	(x) = (__force __typeof__(*(ptr)))__gu_val;			\
e68c825b include/asm-powerpc/uaccess.h      Benjamin Herrenschmidt 2007-04-11  297  	__gu_err;						\
e68c825b include/asm-powerpc/uaccess.h      Benjamin Herrenschmidt 2007-04-11  298  })
e68c825b include/asm-powerpc/uaccess.h      Benjamin Herrenschmidt 2007-04-11  299  
e68c825b include/asm-powerpc/uaccess.h      Benjamin Herrenschmidt 2007-04-11  300  
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  301  /* more complex routines */
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  302  
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  303  extern unsigned long __copy_tofrom_user(void __user *to,
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  304  		const void __user *from, unsigned long size);
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  305  
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  306  #ifndef __powerpc64__
5015b494 include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-31  307  
4cfbdfff include/asm-powerpc/uaccess.h      Adrian Bunk            2006-12-01  308  static inline unsigned long copy_from_user(void *to,
5015b494 include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-31  309  		const void __user *from, unsigned long n)
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  310  {
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29 @311  	unsigned long over;
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  312  
8346f23b arch/powerpc/include/asm/uaccess.h Al Viro                2016-08-21  313  	if (likely(access_ok(VERIFY_READ, from, n))) {
1d3c1324 arch/powerpc/include/asm/uaccess.h Kees Cook              2016-06-23  314  		if (!__builtin_constant_p(n))
1d3c1324 arch/powerpc/include/asm/uaccess.h Kees Cook              2016-06-23  315  			check_object_size(to, n, false);
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  316  		return __copy_tofrom_user((__force void __user *)to, from, n);
1d3c1324 arch/powerpc/include/asm/uaccess.h Kees Cook              2016-06-23  317  	}
8346f23b arch/powerpc/include/asm/uaccess.h Al Viro                2016-08-21  318  	memset(to, 0, n);
2df5e8bc include/asm-powerpc/uaccess.h      Stephen Rothwell       2005-10-29  319  	return n;

:::::: The code at line 311 was first introduced by commit
:::::: 2df5e8bcca53e528a78ee0e3b114d0d21dd6d043 powerpc: merge uaccess.h

:::::: TO: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
:::::: CC: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux