Re: [PATCH] fscrypto: require write access to mount to set encryption policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 08, 2016 at 02:20:38PM -0700, Eric Biggers wrote:
> [To apply cleanly, my other two patches must be applied before this one]
> 
> Since setting an encryption policy requires writing metadata to the
> filesystem, it should be guarded by mnt_want_write/mnt_drop_write.
> Otherwise, a user could cause a write to a frozen or readonly
> filesystem.  This was handled correctly by f2fs but not by ext4.  Make
> fscrypt_process_policy() handle it rather than relying on the filesystem
> to get it right.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 4.1+; check fs/{ext4,f2fs}

Thanks, I have this in the ext4.git's fixes branch, but I plan to only
send the other two fixes to Linus, since (a) they are more critical,
and I'd prefer to get an Acked-by from Jaeguk or Changman (as the f2fs
maintainers) before I send this fix to Linus, since it touches f2fs.

Jaeguk, Changman, any objections?

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux