> On Aug 20, 2016, at 2:18 AM, Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Fri, Aug 19, 2016 at 05:08:44PM -0400, J. Bruce Fields wrote:
>> I thought I remembered Christoph (cc'd) arguing at the 2015 lsf/mm that
>> there were some more issues that would need to be taken care of before
>> we could turn on cross-device copies.
>
> Yes. Noi other VFS operation is supported between mountpoint, so
> copy_file_range shouldn't be either.
Hi Christoph
As you know (because you reviewed the patch), the original intent of vs_copy_file_range as stated in the syscall submission from Zach Brown (commit: 884a12a5972fc867a93f7adf7a8ac2ade5d38fff ) is to allow copies between file systems “once we get implementations which copy between tile systems safely”
NFSv4 inter server to server copy will provide an implementation which can copy between tile systems safely - so I don’t understand your objection to this eventual use of vfs_copy_file_range.
>
> Also a general NAK to any new copy_file_range work before we have
> proper xfstests coverage. And it's not like the coverage is hard,
> we already have 100s of tests for clone, which in many way is very
> similar and could be partially reused.
Yes - agreed. Anna is working on updated xfstests for NFSv4 intra server to server copy as well as expanding the xfstests for other vfs_copy_file_range features. We can look at expanding the tests for the inter server to server case. Jorge Mora author of NFSTests is also working on a test suite for inter server to server copy.
��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
