Jan Kara <jack@xxxxxxx> wrote: > But if you 'goto out' in some branches, we loose the ext3_warning() > which we probably don't want. Ugh. Okay, I need to rework the changes to that function. > > return ERR_PTR(-EACCES); > Wouldn't here -EIO be more appropriate? I would have thought so, but -EACCES was what it returned before I touched it. OTOH, it's calling ext3_error(), so EIO ought to be the right thing to do. I'll alter it and see if anyone complains. > Why don't we use PTR_ERR() always? Is there some reason not to return > -EIO? I do wonder why it used to return EINVAL rather than EIO. It's understandable if the magic number doesn't match, but if it appears to be an otherwise corrupt filesystem, then yes, I guess it should return EIO. I'll change it. David - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
