On Mon, 1 Oct 2007, Zach Brown wrote: > > If you're soliciting opinions, I think I tend to prefer the feel of the > code paths after the changes. I don't know the benefits of the change > are worth the risk in unmaintained file systems, though. > > > + return ERR_PTR(PTR_ERR(inode)); > > This caught my eye. Surely we can do better :). It seems to happen a > few times in the patches, the instance in this patch was the first that > I noticed. Yeah. The above obviously *should* be the same as return inode; apart from a few casts. But if the casts matter, there's something else wrong. Linus - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
