On Thu, Aug 4, 2016 at 10:10 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> Fix a fat-fingered conversion to the req_op accessors, and also
> use a switch statement to make it more obvious what is being checked.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Dave Chinner <david@xxxxxxxxxxxxx>
> Fixes: c2df40 ("drivers: use req op accessor");
> ---
> drivers/block/loop.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 075377e..91c2c88 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1659,11 +1659,15 @@ static int loop_queue_rq(struct blk_mq_hw_ctx *hctx,
> if (lo->lo_state != Lo_bound)
> return -EIO;
>
> - if (lo->use_dio && (req_op(cmd->rq) != REQ_OP_FLUSH ||
> - req_op(cmd->rq) == REQ_OP_DISCARD))
> - cmd->use_aio = true;
> - else
> + switch (req_op(cmd->rq)) {
> + case REQ_OP_FLUSH:
> + case REQ_OP_DISCARD:
> cmd->use_aio = false;
> + break;
> + default:
> + cmd->use_aio = lo->use_dio;
> + break;
> + }
Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
>
> queue_kthread_work(&lo->worker, &cmd->work);
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
