On Wed, Jul 27, 2016 at 11:29 AM, Jens Axboe <axboe@xxxxxx> wrote:
>
> Looks OK to me, though I think you could have dropped the ->bi_rw
> assignment in f2fs_submit_page_bio():
>
> bio->bi_rw = fio->op_flags;
> bio_set_op_attrs(bio, fio->op, fio->op_flags);
>
> __submit_bio(fio->sbi, bio, fio->type);
Ahh, yes. I'll add a patch to drop that line, unless you just want to
do it yourself (or Jaegeuk Kim wants to do it in the f2fs tree).
Jaegeuk, I'd still really want confirmation that it all actually
works. The extra line should be harmless, even if Jens is right that
it is ugly and wrong. It might be worth testing with that line
removed.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
