Re: [patch]anon_inodes.c: fix error check in anon_inode_getfd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <yanzheng@xxxxxxxx> wrote:

> Hello,
> 
> igrab return NULL on error.
> 
> Signed-off-by: Yan Zheng<yanzheng@xxxxxxxx>
> ---
> diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.c
> --- linux-2.6.23-rc8/fs/anon_inodes.c	2007-09-27 10:05:07.000000000 +0800
> +++ linux/fs/anon_inodes.c	2007-09-27 10:18:26.000000000 +0800
> @@ -87,8 +87,8 @@
>  		return -ENFILE;
> 
>  	inode = igrab(anon_inode_inode);
> -	if (IS_ERR(inode)) {
> -		error = PTR_ERR(inode);
> +	if (!inode) {
> +		error = -ENOENT;
>  		goto err_put_filp;
>  	}

hm, does that code actually need to exist?  igrab() is pretty expensive and
that fs is permanently mounted anyway...

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux