On Sat, Sep 15, 2007 at 12:58:03AM +1000, Greg Banks wrote: > These patches look good, and cleanup in this area is certainly a > good thing. One small comment: the easy filesystems (ext[234], efs, > ntfs) might be cleaner if the per-fs get_inode function were a member > of export_ops instead of an extra argument to generic_fh_to_dentry(). > That way you wouldn't need these two little helper functions in each > filesystem, because you could point export_ops.fh_to_dentry directly > at generic_fh_to_dentry. I was pondering this, but in the end I prefer the cleaner layering of the callback version. This also mirrors what we do in other areas (e.g. address_space operations) - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
