On Thu, Aug 30, 2007 at 03:16:32PM +0200, Christoph Hellwig wrote: > Trivial switch over to the new generic helpers. > - result = ERR_PTR(-ESTALE); > - goto out_iput; > + iput(inode); > + return ERR_PTR(-ESTALE); For some reason you're introducing a bunch of whitespace damage on lines like that last one. Would you mind running these through checkpatch.pl or whatever and then resending? Other than that I can't find any problem, and it seems like an obvious improvement, though I'd like to see Neil take a look. Do you want these added to the nfsd patches for 2.6.24? --b. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
