On Thu, Aug 30, 2007 at 11:06:38AM -0400, Jeff Layton wrote: > Make notify_change not clear the ATTR_KILL_S*ID bits in the ia_vaid that > gets passed to the setattr inode operation. This allows the filesystems > to reinterpret whether this mode change is simply intended to clear the > setuid/setgid bits. > > This means that notify_change should never be called with both ATTR_MODE > and either of the ATTR_KILL_S*ID bits set, since the filesystem would > have no way to know what part of the mode change was intentional. If > it is called this way, consider it a BUG(). This one looks fine to, but you'll probably need an additional patch to ecryptfs so it clears ATTR_MODE before calling notify_change for the lower inode. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
