On Mon, Aug 13 2007, Daniel Phillips wrote: > On Monday 13 August 2007 03:06, Jens Axboe wrote: > > On Mon, Aug 13 2007, Daniel Phillips wrote: > > > Of course not. Nothing I said stops endio from being called in the > > > usual way as well. For this to work, endio just needs to know that > > > one call means "end" and the other means "destroy", this is > > > trivial. > > > > Sorry Daniel, but your suggestions would do nothing more than uglify > > the code and design. > > Pretty much exactly what was said about shrinking struct page, ask Bill. > The difference was, shrinking struct page actually mattered whereas > shrinking struct bio does not, and neither does expanding it by a few > bytes. Lets back this up a bit - this whole thing began with you saying that struct bio was bloated already, which I said wasn't true. You then continued to hand wave your wave through various suggestions to trim the obvious fat from that structure, none of which were nice or feasible. I never compared the bio to struct page, I'd obviously agree that shrinking struct page was a worthy goal and that it'd be ok to uglify some code to do that. The same isn't true for struct bio. And we can expand struct bio if we have to, naturally. And I've done it before, which I wrote in the initial mail. I just don't want to do it casually, then it WILL be bloated all of a sudden. Your laissez faire attitude towards adding members to struct bio "oh I'll just add it and someone less lazy than me will fix it up in the future" makes me happy that you are not maintaining anything that I use. I'll stop replying to your mails until something interesting surfaces. I've already made my points clear about both the above and the throttling. And I'd advise you to let Evgeniy take this forward, he seems a lot more adept to actually getting CODE done and - at least from my current and past perspective - is someone you can actually have a fruitful conversation with. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
