I'm getting a lot of warnings about struct super_block in 2.6.23-rc2. Then, a compile error when compiling fs/drop_caches.o: CC fs/drop_caches.o In file included from fs/drop_caches.c:7: include/linux/mm.h:1210: warning: 'struct super_block' declared inside parameter list include/linux/mm.h:1210: warning: its scope is only this definition or declaration, which is probably not what you want fs/drop_caches.c:17: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here fs/drop_caches.c:28: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here make[1]: *** [fs/drop_caches.o] Error 1 make: *** [fs] Error 2 I'm using Linus's tree, which is 2.6.23-rc2 plus all patches up to this commit: commit ac07860264bd2b18834d3fa3be47032115524cea Author: Jesper Juhl <jesper.juhl@xxxxxxxxx> Date: Wed Aug 8 16:31:30 2007 -0700 I didn't check if this is fixed already in the latest -mm. The following small fix seems to get rid of all warnings and compile errors I've seen: diff --git a/include/linux/mm.h b/include/linux/mm.h index 324c151..ed90191 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -20,6 +20,7 @@ struct anon_vma; struct file_ra_state; struct user_struct; struct writeback_control; +struct super_block; #ifndef CONFIG_DISCONTIGMEM /* Don't use mapnrs, do it properly */ extern unsigned long max_mapnr; Cheers, Erez. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html