Re: [Patch 05/18] fs/logfs/dir.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2007-08-08 at 19:15 +0200, Jörn Engel wrote:
> On Wed, 8 August 2007 20:07:34 +0300, Artem Bityutskiy wrote:
> > On Wed, 2007-08-08 at 18:16 +0200, Jörn Engel wrote:
> > > +static inline void logfs_inc_count(struct inode *inode)
> > > +{
> > > +	inode->i_nlink++;
> > > +	mark_inode_dirty_sync(inode);
> > > +}
> > > +
> > > +static inline void logfs_dec_count(struct inode *inode)
> > > +{
> > > +	inode->i_nlink--;
> > > +	mark_inode_dirty_sync(inode);
> > > +}
> > include/linux/fs.h: inode_inc_link_count() inode_dec_link_count() do
> > this. Although not sure they exist in the old kernel your patches are
> > against.
> 
> Almost, they call mark_inode_dirty() instead of mark_inode_dirty_sync().
> I wonder if that's necessary.
> 
Ah, right, it is necessary as long as you do not have write-back
implemented, sure. Pardon :-)

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux