Hi Amit, >> Could you please review the changes, and the FIXMEs. > > Please find my comments below.. Thanks. [...] >> .SH DESCRIPTION >> .BR fallocate () >> allows the caller to directly manipulate the allocated disk space >> for the file referred to by >> .I fd >> for the byte range starting at >> .I offset >> and continuing for >> .I len >> bytes. >> .\" FIXME Amit: in other words the affected byte range >> .\" is the bytes from (offset) to (offset + len - 1), right? > > <Amit> > Yes, you are right. > </Amit> [...] >> Preallocating blocks does not change >> the file size (as reported by >> .BR stat (2)) >> even if it is less than >> .\" FIXME Amit: "offset + len" is written here. But should it be >> .\" "offset + len - 1" ? > > <Amit> > Good point. This text was directly taken from the man page of > posix_fallocate and is also there on the posix specifications at: > http://www.opengroup.org/onlinepubs/009695399/functions/posix_fallocate.html > > The current posix_fallocate() implementation and also the fallocate() > implementation in ext4 are based on above documentation, wherein EOF is > compared with "offset + len" and not with "offset + len - 1". > > I am not sure if this is right or wrong. But, this is as per posix > specifications. ;) > </Amit> Ahhh -- the off by one error was inside my head! Obviously if we allocate bytes for offset 1000, len 100, then the affected byte range would run to offset 1099, giving a file size of 1100 bytes -- that is (offset + len) -- not (offset + len - 1), which is of course the offset of the last byte. Sorry for the confusion. [...] >> .B ENOSYS >> The file system containing the file system referred to by > > <Amit> > There is a typo above. We have "file system" repeated twice in above > sentence. Second one should be "file". > </Amit> Thanks for catching that. Okay -- it seems that this page is pretty much ready for publication, right? I'll hold off for a bit, until nearer the end of the 2.6.23 cycle. Cheers, Michael -- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 Want to help with man page maintenance? Grab the latest tarball at http://www.kernel.org/pub/linux/docs/manpages/ read the HOWTOHELP file and grep the source files for 'FIXME'. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
