On Wed, 2007-07-18 at 17:37 -0400, Jeff Garzik wrote: > It seems jbd_debug() might need modification: > > fs/ext4/inode.c: In function ‘ext4_write_inode’: > fs/ext4/inode.c:2906: warning: comparison is always true due to limited > range of data type > > fs/jbd2/recovery.c: In function ‘jbd2_journal_recover’: > fs/jbd2/recovery.c:254: warning: comparison is always true due to > limited range of data type > fs/jbd2/recovery.c:257: warning: comparison is always true due to > limited range of data type > > fs/jbd2/recovery.c: In function ‘jbd2_journal_skip_recovery’: > fs/jbd2/recovery.c:301: warning: comparison is always true due to > limited range of data type > > I'm surprised this was not noticed in a test build before pushing upstream. > Hmm, I am not sure what happened. I get the compile warning on linus latest git tree, but could not get the same compile warning on Ted's ext4 git tree. In both build CONFIG_JBD2_DEBUG and DEBUG_FS is enabled. Mingming - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html