On Wed, 11 Jul 2007 00:38:09 -0500 "Jose R. Santos" <jrs@xxxxxxxxxx> wrote: > > > Alternatively (and preferably) do this via an update to > > Documentation/filesystems/ext4.txt. > > Seems like I also need to update the doc on Kconfig as well. Do you > prefer this in separate patches? (current patch, kconfig patch, ext4 > doc update patch? All these changes are logically connected (aren't they?). A single patch is fine. > > Shoudln't all this debug info be a per-superblock thing rather than > > kernel-wide? > > I don't think it is worth pursuing this feature since this seems to > have been broken for a while now (its been there since the first git > revission in ext3) and nobody has noticed it until now. It could be > address on a later patch though, since the initial purpose of the patch > was to fix the broken JBD2_DEBUG option. Of course, this may not be > clearly express in the changelog. :) > I don't think that making it all per-superblock is worth the effort - it's a developer-only thing and developer will have the knowledge to test ext4 on an otherwise-ext3 setup if they're really fussed about the accuracy. So yes, a bare make-it-work patch sounds appropriate. Or remove it, but hey, it might be useful. The timestamping stuff certainly looks useful. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
