Re: [PATCH] Faster ext2_clear_inode()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 09, 2007 at 10:34:32AM +0200, Jörn Engel wrote:
> On Mon, 9 July 2007 08:11:22 +0400, Alexey Dobriyan wrote:
> > 
> > If CONFIG_EXT2_FS_POSIX_ACL is not configured, ext2_clear_inode() will be empty
> > function. However, there still will be call and immediate return which can be
> > avoided.
> > [...]
> > +#ifdef CONFIG_EXT2_FS_POSIX_ACL
> >  static void ext2_clear_inode(struct inode *inode)
> >  {
> > -#ifdef CONFIG_EXT2_FS_POSIX_ACL
> >  	struct ext2_inode_info *ei = EXT2_I(inode);
> >  
> >  	if (ei->i_acl && ei->i_acl != EXT2_ACL_NOT_CACHED) {
> > @@ -197,8 +197,10 @@ static void ext2_clear_inode(struct inode *inode)
> >  		posix_acl_release(ei->i_default_acl);
> >  		ei->i_default_acl = EXT2_ACL_NOT_CACHED;
> >  	}
> > -#endif
> >  }
> > +#else
> > +#define ext2_clear_inode NULL
> > +#endif
> 
> Are you sure your patch makes a difference?  Does the resulting binary
> change at all?

Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
empty, it leaves traces in resulting kernel.

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux