On Sat, 2007-06-30 at 10:37 +0100, Christoph Hellwig wrote:
> > --- lxc/fs/namei.c~numa_mnt_want_write 2007-06-25 11:05:50.000000000 -0700
> > +++ lxc-dave/fs/namei.c 2007-06-25 11:05:50.000000000 -0700
> > @@ -230,10 +230,12 @@ int permission(struct inode *inode, int
> > int retval, submask;
> >
> > if (mask & MAY_WRITE) {
> > -
> > /*
> > - * Nobody gets write access to a read-only fs.
> > + * If this WARN_ON() is hit, it likely means that
> > + * there was a missed mnt_want_write() on the path
> > + * leading here.
> > */
> > + WARN_ON(__mnt_is_readonly(nd->mnt));
> > if (IS_RDONLY(inode) &&
>
> I might be missing something, but wouldn't this trip an
>
> access("/foo/bar", W_OK);
>
> On a readonly filesystem?
Yes, it will. I will re-work it a bit.
-- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
