Re: [PATCH 14/26] elevate write count for file_update_time()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 25, 2007 at 11:32:08AM -0700, Dave Hansen wrote:
> How does this look?
> 
> -       if (IS_RDONLY(inode))
> +       /*
> +        * Ideally, we want to guarantee that 'f_vfsmnt'
> +        * is non-NULL here.  But, NFS exports need to
> +        * be fixed up before we can do that.  So, check
> +        * it for now. - Dave Hansen
> +        */
> +       if (file->f_vfsmnt)
> +               err = mnt_want_write(file->f_vfsmnt);
> +       if (err)
>                 return;

Looks okay.  Unfortunately we've grown some more callers of dentry_open
with a NULL vfsmount in the meantime (*grasp* reiserfs xattr mess *grasp*)
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux