On Mon, Jun 25, 2007 at 11:32:08AM -0700, Dave Hansen wrote: > How does this look? > > - if (IS_RDONLY(inode)) > + /* > + * Ideally, we want to guarantee that 'f_vfsmnt' > + * is non-NULL here. But, NFS exports need to > + * be fixed up before we can do that. So, check > + * it for now. - Dave Hansen > + */ > + if (file->f_vfsmnt) > + err = mnt_want_write(file->f_vfsmnt); > + if (err) > return; Looks okay. Unfortunately we've grown some more callers of dentry_open with a NULL vfsmount in the meantime (*grasp* reiserfs xattr mess *grasp*) - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html