On Mon, 2007-06-25 at 11:27 -0700, Dave Hansen wrote: > On Sat, 2007-06-23 at 08:45 +0100, Christoph Hellwig wrote: > > You probably want to add a big comment explaining why it's fine here. > > I've got this in the next set: > > - > - if(IS_RDONLY(nd.dentry->d_inode)) > + /* > + * This is a rare case where using __mnt_is_readonly() > + * is OK without a mnt_want/drop_write() pair. Since > + * not actual write to the fs is performed here, we do s/not/no/ > + * not need to telegraph to that to anyone. Also, we > + * accept that access is inherently racy, and know that > + * the fs might be remounted between this syscall, and > + * any action taken because of its result. > + */ > + if (__mnt_is_readonly(nd.mnt)) > res = -EROFS; > -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
