Re: [PATCH 25/26] r/o bind mounts: scalable writer count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2007-06-23 at 13:28 +0200, Miklos Szeredi wrote:
> 
> I'd suggest something along these lines in final mntput:
> 
>         lock_and_coalesce_cpu_mnt_writer_counts();
>         mnt_unlock_cpus();
>         BUG_ON(atomic_read(&mnt->__mnt_writers));
> 
> since there's basically no other we'll notice if there _is_ an
> imbalance.

That's a very good idea.  I've added that check, but a WARN_ON() instead
of a BUG_ON().

Does __mntput() seem like the right place to you?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux