On Sat, 2007-06-23 at 08:47 +0100, Christoph Hellwig wrote: > On Fri, Jun 22, 2007 at 01:03:22PM -0700, Dave Hansen wrote: > > This area of code is currently #ifdef'd out, so add a comment > > for the time when it is actually used. > > Ok. Does this clash with the user mount patches? Even if it does > I think we want this patch first in the series and fix the user mounts > up ontop of it. It will clash with those, but they completely drops the call to vfs_permission() in here. As I think about this again, we really don't care about r/o bind mounts here, _only_ the vfs permissions. If it is a r/o bind mount we want to be able to mount something writable on top of it because we're never actually writing to the mount *itself*. I think this patch can just go away now. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html