On Tuesday April 24, npiggin@xxxxxxx wrote: > On Tue, Apr 24, 2007 at 12:11:19PM +0100, Christoph Hellwig wrote: > > On Tue, Apr 24, 2007 at 01:05:49PM +0200, Nick Piggin wrote: > > > On Tue, Apr 24, 2007 at 11:46:47AM +0100, Christoph Hellwig wrote: > > > > > + page = __grab_cache_page(mapping, index); > > > > > > > > btw, __grab_cache_page should probably get a more descriptive and > > > > non-__-prefixed name now that it's used all over the place. > > > > > > Agreed. Suggestions? ;) > > > > find_or_create_cache_page given that's it's like find_or_create_page + > > add_to_page_cache? > > find_or_create_page adds to page cache as well, though :P I would really like to see the word 'lock' in there, as it does return a locked page, and when I first saw __grab_cache_page recently there was an unlock_page afterwards and I couldn't see where the lock happened, and I was confused for a little while. NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
