Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/12/07, Phillip Lougher <phillip@xxxxxxxxxxxxxxxxxxx> wrote:
Nate Diller wrote:

> +     page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping,
> +                             start >> PAGE_CACHE_SHIFT,
> +                             (void *)jffs2_do_readpage_unlock,
> +                             OFNI_EDONI_2SFFJ(f));
>
> -     if (IS_ERR(pg_ptr)) {
> +     if (IS_ERR(page)) {
>               printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(pg_ptr));

should be

                printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(page));

> -             return PTR_ERR(pg_ptr);
> +             return PTR_ERR(page);


wow, you're right.  I was sure I compile-tested this ... oh, "depends
on MTD".  oops.

thanks for reviewing.  does it look OK to you otherwise?

NATE
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux