On Thu, Apr 05, 2007 at 08:21:54AM -0700, Badari Pulavarty wrote:
> On Thu, 2007-04-05 at 04:08 +0200, Nick Piggin wrote:
> >
> > ->readpage can still return AOP_TRUNCATED_PAGE. Were there any from
> > prepare_write or commit_write still around?
> >
> >
>
> Not a big deal. But trying to understand it better.
>
>
> int pagecache_write_begin()
> {
>
> if (aops->write_begin) {
> return aops->write_begin(file, mapping, pos, len, flags,
> pagep, fsdata);
> } else {
> .....
> ret = aops->readpage(file, page);
> page_cache_release(page);
> if (ret) {
> if (ret == AOP_TRUNCATED_PAGE)
> goto again;
> return ret;
> }
> goto again;
>
> ....
> }
> }
>
> filesystems (ocfs2, gfs2) which can return AOP_TRUNCATED_PAGE for
> prepare_write or readpage would never come to this case. They
> have write_begin() method set. Isn't it ? Why this check ?
Ah you're right. In that case, I'll replace that with a comment ;)
Thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
