On Thu, Apr 05, 2007 at 08:45:29AM +0100, Christoph Hellwig wrote: > On Thu, Apr 05, 2007 at 04:13:05AM +0200, Nick Piggin wrote: > > > On a related note - what's the rules for a perform_write() implementation? > > > I noticed that wasn't documented with write_begin and write_end and > > > I don't see any other filesystem implementing it yet.... > > > > Ah, so it isn't, thanks I'll document it. (today I'm looking at doing a > > simple_perform_write and perhaps another easy one, which should also help > > filesystem maintainers to have a reference). > > I think ->perform_write should go away. It's really just duplicating > ->write for the !O_DIRECT case. Instead we should factor the remaining > bits of generic_file_aio_write into nice helpers so that people that don't > want to use the generic part can build their own ->write from these pieces. I probably don't disagree with you. If we use the iov_iter further down the stack (which I was going to do as a cleanup following this patchset), then you're right that it isn't too painful... Anyway, I'll leave it in the next release: I've converted a few users, so that will give people a better idea of whether they agree/disagree or don't care ;) - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
